Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
+ Coverage 87.05% 87.11% +0.05%
==========================================
Files 93 93
Lines 6367 6356 -11
Branches 111 111
==========================================
- Hits 5543 5537 -6
+ Misses 768 764 -4
+ Partials 56 55 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Looks like the e2e-tests indeed need to be adapted to the changes on this branch |
Member
Author
I'll close the older PR in favor of this one, will check and update the relevant e2e tests in this branch |
nooreldeenmansour
force-pushed
the
improve-login-layout
branch
from
24c0845 to
97991c9
Compare
nooreldeenmansour
force-pushed
the
improve-login-layout
branch
from
97991c9 to
daf4285
Compare
nooreldeenmansour
force-pushed
the
improve-login-layout
branch
from
daf4285 to
968620c
Compare
nooreldeenmansour
force-pushed
the
improve-login-layout
branch
from
968620c to
f679b56
Compare
Member
Author
|
The URL/code matching should now be working fine, but I had to make the regex backwards compatible for the migration tests. please take another look and tell me what u think |
adombeck
approved these changes
Apr 15, 2026
3v1n0
reviewed
Apr 15, 2026
3v1n0
reviewed
Apr 17, 2026
nooreldeenmansour
added a commit
that referenced
this pull request
Apr 17, 2026
Replace hardcoded extra spaces in the URL/Code format strings with a shared `formatAlignedFields` helper that computes padding at runtime based on label widths. This ensures consistent visual alignment regardless of label length, making the output safe for future translations. Follow-up to #1437
nooreldeenmansour
added a commit
that referenced
this pull request
Apr 17, 2026
Replace hardcoded extra spaces in the URL/Code format strings with a shared `formatAlignedFields` helper that computes padding at runtime based on label widths. This ensures consistent visual alignment regardless of label length, making the output safe for future translations. Follow-up to #1437
nooreldeenmansour
added a commit
that referenced
this pull request
Apr 17, 2026
Replace hardcoded extra spaces in the URL/Code format strings with a shared `formatAlignedFields` helper that computes padding at runtime based on label widths. This ensures consistent visual alignment regardless of label length, making the output safe for future translations. Follow-up to #1437
nooreldeenmansour
added a commit
that referenced
this pull request
Apr 17, 2026
Replace hardcoded extra spaces in the URL/Code format strings with a shared `formatAlignedFields` helper that computes padding at runtime based on label widths. This ensures consistent visual alignment regardless of label length, making the output safe for future translations. Follow-up to #1437
nooreldeenmansour
added a commit
that referenced
this pull request
Apr 22, 2026
Replace hardcoded extra spaces in the URL/Code format strings with a shared `formatAlignedFields` helper that computes padding at runtime based on label widths. This ensures consistent visual alignment regardless of label length, making the output safe for future translations. Follow-up to #1437
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1263
UDENG-9622
forked branch PR: #1266
This was created to run e2e tests