Fix: Ensure first element is retrieved from associative array#127
Open
egyjs wants to merge 1 commit intocalebporzio:mainfrom
Open
Fix: Ensure first element is retrieved from associative array#127egyjs wants to merge 1 commit intocalebporzio:mainfrom
egyjs wants to merge 1 commit intocalebporzio:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed:
Replaced:
with:
Why:
In cases where
$rowsis not zero-indexed (e.g. after afilter()or manually assigned keys), trying to access$rows[0]throws:Example:
Accessing
$rows[0]will trigger the exception above because key0doesn't exist.Fix:
array_values($rows)[0]reindexes the array numerically, so the first element is always at index0regardless of the original keys.This ensures the code works correctly with any numerically keyed array.