Skip to content

fix(website): bucket A — landing & docs polish - #68

Merged
blove merged 2 commits into
mainfrom
fix/landing-bucket-a
May 3, 2026
Merged

blove merged 2 commits into
mainfrom
fix/landing-bucket-a

Conversation

@blove

@blove blove commented May 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Six concrete review-fixes from the landing-page pass. No design changes — buckets B (hero IA), C (visual polish), and D (streaming story) follow in separate PRs.

Changes

# What Where
1 Remove "Grid Alpha clips wrapped content" callout under Receipts ReceiptsBand.tsx, test updated
2 Shorten "How we compare" subtitle from 4 lines to 1 + methodology link ComparisonTable.tsx
3 CTA npm install button — legible inverted hover (bg-text-primary + bg-page text) + cursor-pointer CopyCommand.tsx
4 "Show the grid" / Esc / close strips drawer-section hash via replaceState so reload after close stays on the grid useDrawer.ts
5 Docs prose: add table styling (border-collapse, header bg, padding, last-row no-border) inside overflow-x-auto so wide reference tables scroll within the 68ch column instead of falling back to browser-default rendering docs/layout.tsx
6 Docs sidebar: reorder Grid before Theming (matches consumer journey: install → use the grid → then theme it) docs/_nav.ts

Verified in Chrome (localhost:3000)

  • ✅ Grid Alpha claim removed from Receipts
  • ✅ Compare subtitle one tight line; "See the methodology →" links out
  • ✅ CTA button has cursor: pointer, hover is legible (no more dark-on-dark)
  • ✅ /#receipts deep-link auto-opens drawer; clicking "Show the grid" → URL becomes /, drawer closes; reload stays on grid
  • ✅ Docs token-reference page tables now render with borders + padding instead of unstyled HTML
  • ✅ Docs sidebar shows: Getting Started → Grid → Theming

Test plan

  • pnpm --filter @pretable/app-website test — 72/72 pass
  • Chrome MCP visual verification (above)

Six concrete fixes from review:
- Remove "AG Grid clips wrapped content" callout under Receipts
- Shorten "How we compare" subtitle to one tight line + methodology link
- CopyCommand (CTA install): legible inverted hover + cursor-pointer
- close() drawer also strips drawer-section hash via replaceState so
  reload after "Show the grid" / Esc / close stays on the grid
- Docs prose: add table styling (border, padding, header bg, last-row no-border)
  with overflow-x-auto wrapper so wide reference tables scroll within column
- Docs sidebar: reorder Grid before Theming (matches consumer journey)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented May 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
pretable Ignored Ignored May 3, 2026 2:52pm

Request Review

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Vercel preview ready

Preview: https://pretable-f3x8hl5n0-cacheplane.vercel.app
Commit: b6987cdf6ef531fd98c5075064c6eb1aabe94dda

Updated automatically by the deploy-preview job.

@blove
blove merged commit 8f56970 into main May 3, 2026
10 checks passed
@blove
blove deleted the fix/landing-bucket-a branch May 3, 2026 14:56
blove added a commit that referenced this pull request May 3, 2026
The docs Token Reference and other reference pages were rendering raw `|`
pipe characters instead of tables, because @next/mdx was configured with
no remark plugins — GitHub-flavored markdown table syntax requires
remark-gfm. YAML frontmatter (--- title: ... ---) was leaking as <hr> +
<h2> for the same reason: no frontmatter parser.

Add both plugins to the createMDX options. Pass them as string-form tuples
so Turbopack can serialize the loader options (function references break
with "does not have serializable options"). The previously-merged table
prose styles (PR #68) now have actual <table> elements to style.

Verified locally at /docs/theming/token-reference: 7 tables render with
borders + padding, frontmatter no longer visible, no console errors.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant