Repository navigation
refactor(react): collapse internal react-surface into @pretable/react - #66
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Vercel preview readyPreview: https://pretable-ao0eani2o-cacheplane.vercel.app Updated automatically by the |
This was referenced May 3, 2026
Merged
Merged
blove
added a commit
that referenced
this pull request
May 3, 2026
- New /docs/grid/pretable-surface page documenting the kitchen-sink component made public in PR #66 (collapse react-surface). Covers full prop table, telemetry stability gotcha, streaming demo example, and when to use it vs <Pretable>. - _nav: insert "<PretableSurface> component" between Pretable and Custom rendering. - eventLog.ts:134: stale "p95=9.3ms" in fake metrics-flushed message updated to "p95=16ms" matching the bench median + ReceiptsBand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collapses the private
@pretable-internal/react-surfaceworkspace package into the public@pretable/react. All grid components (<PretableSurface>,<InspectionGrid>,<LabeledGridSurface>) become public exports. The opinionated<Pretable>preset stays.Spec: docs/superpowers/specs/2026-05-03-collapse-react-surface-design.md
Plan: docs/superpowers/plans/2026-05-03-collapse-react-surface.md
Why
<Pretable>(hardcodedviewportHeight={320}, hardcoded cell renderers). The kitchen-sink components the website + bench use were locked away.What changed
packages/react-surface/src/→packages/react/src/(viagit mv, history preserved)packages/react/src/index.tsnow exports everything publicly (components, hooks, helpers, types)packages/react-surface/deleted<PretableSurface>'sinteractionStateprop marked@experimental(bench-internal feature exposed for advanced consumers)apps/website,apps/bench,apps/streaming-demonow import from@pretable/react@pretable/reactminor bump (0.0.1 → 0.1.0)rendering.ts,styles.ts) live inpackages/react/src/but stay out ofindex.tsWedge integrity
Before: bench imports
@pretable-internal/react-surface(workspace), npm consumers get a different surface (<Pretable>only).After: bench, website, and npm consumers all import the same public components from
@pretable/react. Honest dogfooding.Verification
pnpm -r buildpnpm typecheckpnpm lintpnpm formatpnpm testpnpm build(root, includes website Next SSG)lint:packaging(publint + attw)@pretable/core,@pretable/react,@cacheplane/json-streamOut of scope
<Pretable>/<PretableSurface>Test plan