Repository navigation
feat(bench): wire @pretable/ui chrome into bench (direction B) - #13
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/benchin<Nav active="bench">+<Footer>from@pretable/ui.apps/bench/src/app.cssagainst@pretable/uidesign tokens using Tailwind v4@theme inline— same pattern shipped for playground in direction A (PR feat(playground): pitch landing (direction A) #12, merged asc29da2b)..viewport-cardand.result-jsonstay on the terminal (--pt-grid-*) palette because they render structured/grid data.@pretable/uitoprepare:depsso cold-checkout dev/build/test/typecheck resolve the CSS imports.vite.config.tspreserves the vitesttestblock (bench merges Vite + Vitest config in one file) while adding thetailwindcss()plugin andVITE_APP_VERSIONdefine — parity with playground where possible, divergent where bench's config structure required it.Direction B of the four-direction website initiative. Scope is narrow per spec — this PR wires the shared chrome only and does NOT touch
bench-app.tsx,bench-runtime.ts,query-state.ts, or any adapter file. The visual-system-design §6 adversarial-redesign project (4-column comparison grid + scorecard + CI history + methodology) is deliberately deferred.No new unit tests — Nav/Footer component contracts are already covered by playground's
app.test.tsxfrom direction A.Full spec:
docs/superpowers/specs/2026-04-21-bench-ui-integration-design.mdPlan:
docs/superpowers/plans/2026-04-21-bench-ui-integration.mdKnown follow-ups
ciStatusin<Footer>remains hardcoded"green"— same pattern as playground, same TODO comment. Real wiring is a separate future task..bench-adapter-*scope divs withisolation: isolate) is a cheap follow-up.Test plan
pnpm test— 42/42 bench tests pass; full monorepo suite greenpnpm typecheck— cleanpnpm lint— cleanpnpm format— cleanpnpm build— bench builds in ~650ms; Fraunces bundled correctlypnpm --filter @pretable/app-bench dev— verify bench renders with shared Nav + Footer, scenario panel + preview panel render against cream-hi,.viewport-cardstays dark, run toolbar button is solid ink, result JSON renders mono on grid-bg, all four adapter renders remain functional