refactor: replace USE_X11 with OS_LINUX for sharing code with Ozone#31
refactor: replace USE_X11 with OS_LINUX for sharing code with Ozone#31
Conversation
🔍 PR Link Analysis🔗 Ranked Links#1 these Wayland patches🔍 The linked comparison shows the upstream Wayland patches that this PR aims to incrementally port, specifically replacing #2 going away🔍 The issue requests prebuilt Electron binaries for Wayland, as current Linux builds rely on X11/GTK and perform poorly on embedded devices using Wayland. #3 commit guidelines🔍 This pull request replaces #4 https://github.com/electron/electron/blob/master/CONTRIBUTING.md🔍 The contributor guidelines outline the process for proposing changes to Electron, including the expectation that contributors follow the code of conduct and that bug reports are closed if inactive for supported versions. #5 chromium#1085700🔍 The webpage explains that replacing #6 these chromium changes🔍 The webpage describes Gerrit's code review system, which is relevant to the PR's goal of upstreaming Wayland patches through a structured review process. |
Description of Change
This pull-request is a small first step in trying to bring support for Wayland to Electron. I'm planning to follow up on this with more pull-requests in an effort to upstream these Wayland patches.
However, those patches will need some adjustments in order to make them compatible with the upcoming Chromium changes (chromium#1085700) which will soon be merged into Electron (#25488). In particular, it should be taken into consideration that the
USE_X11andUSE_OZONEbuild flags are no longer mutually exclusive.Also,
USE_X11is going away so it might be desirable as a long term goal to remove it from Electron too and replace it with the Ozone equivalents.With that in mind, this pull-request replaces a few instances of
#if defined(USE_X11)with#if defined(OS_LINUX)where it was identified that the guarded code could be shared with Ozone.The more meaningful changes will come in the upcoming pull-requests but I'll be waiting for these chromium changes to be pulled into Electron first (#24984, #25488).
Checklist
npm testpassesRelease Notes
Notes: none