Skip to content

refactor: replace USE_X11 with OS_LINUX for sharing code with Ozone#17

Closed
c4rtune wants to merge 1 commit intomainfrom
test-branch
Closed

refactor: replace USE_X11 with OS_LINUX for sharing code with Ozone#17
c4rtune wants to merge 1 commit intomainfrom
test-branch

Conversation

@c4rtune
Copy link
Copy Markdown
Owner

@c4rtune c4rtune commented Apr 29, 2026

Description of Change

This pull-request is a small first step in trying to bring support for Wayland to Electron. I'm planning to follow up on this with more pull-requests in an effort to upstream these Wayland patches.

However, those patches will need some adjustments in order to make them compatible with the upcoming Chromium changes (chromium#1085700) which will soon be merged into Electron (#25488). In particular, it should be taken into consideration that the USE_X11 and USE_OZONE build flags are no longer mutually exclusive.

Also, USE_X11 is going away so it might be desirable as a long term goal to remove it from Electron too and replace it with the Ozone equivalents.

With that in mind, this pull-request replaces a few instances of #if defined(USE_X11) with #if defined(OS_LINUX) where it was identified that the guarded code could be shared with Ozone.

The more meaningful changes will come in the upcoming pull-requests but I'll be waiting for these chromium changes to be pulled into Electron first (#24984, #25488).

Checklist

Release Notes

Notes: none

@MonnetalX
Copy link
Copy Markdown

🔍 PR Link Analysis

🔗 Ranked Links

#1 these Wayland patches

🔍 The referenced comparison shows a series of commits that replace X11-specific code with Ozone-compatible implementations, aligning with the PR's goal of replacing USE_X11 with OS_LINUX to share code with Ozone.

#2 commit guidelines

🔍 The pull request title should follow semantic commit guidelines, using prefixes like feat:, fix:, or refactor: to describe the change type.

#3 going away

🔍 The USE_X11 build flag is being deprecated in favor of Ozone equivalents, so replacing it with OS_LINUX is a necessary step for supporting Wayland in Electron.

#4 these chromium changes

🔍 The USE_X11 build flag is being deprecated in Chromium and will no longer be mutually exclusive with USE_OZONE, so replacing it with OS_LINUX allows code to be shared with Ozone-based platforms like Wayland.

#5 chromium#1085700)

🔍 The USE_X11 build flag is being deprecated in Chromium and will no longer be mutually exclusive with USE_OZONE, so replacing it with OS_LINUX allows shared code paths for both X11 and Wayland (Ozone) support.

#6 #25488

🔍 The USE_X11 build flag is being deprecated and replaced with Ozone equivalents, so this PR replaces #if defined(USE_X11) with #if defined(OS_LINUX) where the guarded code can be shared with Ozone to prepare for Wayland support.

#7 #24984

🔍 The USE_X11 build flag is being deprecated in Chromium and will no longer be mutually exclusive with USE_OZONE, so replacing #if defined(USE_X11) with #if defined(OS_LINUX) allows the same code to work with both X11

@c4rtune c4rtune closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants