Increase the MSRV from 1.63 to 1.65#1594
Open
xtqqczze wants to merge 6 commits intobytecodealliance:mainfrom
Open
Increase the MSRV from 1.63 to 1.65#1594xtqqczze wants to merge 6 commits intobytecodealliance:mainfrom
xtqqczze wants to merge 6 commits intobytecodealliance:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
xtqqczze
force-pushed
the
msrv
branch
4 times, most recently
from
314bb85 to
6af881f
Compare
xtqqczze
changed the title
xtqqczze
force-pushed
the
msrv
branch
5 times, most recently
from
6293781 to
479a020
Compare
xtqqczze
changed the title
sunfishcode
reviewed
May 2, 2026
Member
sunfishcode
left a comment
sunfishcode
left a comment
There was a problem hiding this comment.
Thanks for putting this together! Overall this looks good, with just a few minor comments below:
| The current policy is that the minimum Rust version required to use this crate | ||
| may be increased in minor releases. | ||
|
|
||
| In general, this crate will not increase the minimum supported version of Rust |
Member
There was a problem hiding this comment.
I don't wish to make a commitment to supporting the version in Debian stable, even qualified with "in general". Perhaps it'd be best to just remove this sentence about Debian stable.
| #[cfg(all(test, not(static_assertions)))] | ||
| #[macro_use] | ||
| #[allow(unused_imports)] | ||
| mod static_assertions; |
Member
There was a problem hiding this comment.
With the polyfill removed, we can remove the explicit extern crate too.
xtqqczze
force-pushed
the
msrv
branch
2 times, most recently
from
3874b46 to
d6a9321
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1607 (
libcbumped MSRV to 1.65)