Close the Otii switchboard relays during bench and verify - #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ckpt benchandckpt verifyrun on continuous power, so they do not need the Otii. But when the intermittent-power rig is wired up, the ez-FET's SBW and 3V3 lines reach the target through the Qoitech switchboard relays, which an intermittent run leaves open. Both commands then find no device and silently degrade to compile-only. Closing the relays first lets them run without rewiring the board._otii_device()holds the shared session setup and teardown, leaving the relays as the caller set them.otii_session()layers the relay-open on top, for intermittent runs;intermittent/runner.pyis unchanged.debugger_connection()closes the relays and holds them closed. It is a no-op when no Otii is reachable (package, server, or device missing), so a directly wired board is unaffected.optional_saleae()(all fivebenchcommands) andverify_algorithms()enter it before probing for the device.Testing
On the rig, starting from the open-relay state an intermittent run leaves behind:
mspdebugbefore/inside/afterdebugger_connection(): unreachable, then MSP430FR5994 detected, and still detected after the session shuts down — the relays hold their state once the client and server exit.ckpt bench milp crc --cap 1uF: flashed, timed (12118.86us), and read back NVM counters instead of degrading to compile-only.ckpt verify milp crc --cap 1uF: PASS (baseline=39423 milp=39423).A full
ckpt intermittentrun was not repeated; its only change is where the relay-open happens during teardown, which the runs above exercised.