A-1414: support hosted cache#4028
Merged
Merged
Conversation
|
On it! Follow along with my review here: https://buildkite.com/buildkite/buildsworth-review-pull-request/builds/1215 |
There was a problem hiding this comment.
I read this as L2 rather than an approval because it changes cache-store dispatch/validation in the agent-managed path. I found one non-blocking mismatch around the local-testing URL path.
Want to dig deeper? The full session log is attached to this Buildkite build. Download the session file and open a new pi session with it:
Download the buildsworth logs from build 1215, then answer my questions about the findings.
buildkate
reviewed
Jun 25, 2026
buildkate
reviewed
Jun 25, 2026
buildkate
reviewed
Jun 25, 2026
buildkate
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support hosted cache via Namespace artifact storage, driven by an
nsc://<namespace>cache store URL under theagent_managedstore type.What this does:
NewBlobStoreroutesagent_managedURLs by scheme —nsc://→NscStore, otherwise S3.nsc://<namespace>and passed as--namespaceto thenscCLI (errors if the namespace is missing).validateCacheStorenow acceptss3://,nsc://, andfile://foragent_managed, and rejects unknown schemes.--expires_in 24h(temporary stopgap; TTL refresh-on-access parity with S3 tracked in A-1437).exec.CommandContext, so uploads/downloads abort on context cancel/timeout.local_hosted_agentsstore type (NSC is now reachable only viansc://).Tests are lean and don't require the
nscbinary: URL parsing, namespace passthrough via an injected command-runner seam, validation short-circuiting, andnsc://dispatch. The existingNSC_INTEGRATION_TEST-gated end-to-end test is retained.Follow-ups: A-1437 (TTL refresh, pending upstream), A-1438 (cache busting / invalidation).
Context
A-1414
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
LLM and me.