Skip to content

Stacked review changes for #3996#4027

Merged
jordandcarter merged 2 commits into
pb-1901-agent-debouncing-promised-failurefrom
promise-failure-debounce-cleanup
Jun 25, 2026
Merged

Stacked review changes for #3996#4027
jordandcarter merged 2 commits into
pb-1901-agent-debouncing-promised-failurefrom
promise-failure-debounce-cleanup

Conversation

@moskyb

@moskyb moskyb commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Stacked on #3996

This PR suggests a couple of changes to #3996:

  • Split job api promise failure logic into HTTP stuff (which the handler handles) and coordination (a small, dedicated coordinator object)
  • Job API HTTP errors are now reserved for errors in the job API itself — a 5xx response from the Buildkite Agent API no longer returns an error (though still has to be handled by the caller
  • Makes it so that the HTTP client constructed for the job API to call the agent API retains settings like NO_HTTP2, has the right user agent, etc

@moskyb moskyb requested a review from jordandcarter June 24, 2026 06:07
@moskyb moskyb requested review from a team as code owners June 24, 2026 06:07
@moskyb moskyb added the internal Non-user facing, internal change. label Jun 24, 2026
@moskyb moskyb changed the title Clean up code from promise failure debounce PR Stacked review changes for #3996 Jun 24, 2026
Comment thread jobapi/payloads.go Outdated
@moskyb moskyb requested a review from jordandcarter June 25, 2026 01:47
@jordandcarter jordandcarter merged commit fccf51f into pb-1901-agent-debouncing-promised-failure Jun 25, 2026
4 checks passed
@jordandcarter jordandcarter deleted the promise-failure-debounce-cleanup branch June 25, 2026 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Non-user facing, internal change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants