Skip to content

Add ZSTD ReadOffset support - #362

Merged
EdSchouten merged 2 commits into
buildbarn:mainfrom
snakethatlovesstaticlibs:add-zstd-resumption
Aug 27, 2026
Merged

Add ZSTD ReadOffset support#362
EdSchouten merged 2 commits into
buildbarn:mainfrom
snakethatlovesstaticlibs:add-zstd-resumption

Conversation

@snakethatlovesstaticlibs

@snakethatlovesstaticlibs snakethatlovesstaticlibs commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

This should close #360

AI was used to create this code

Comment thread pkg/blobstore/grpcservers/byte_stream_server_test.go Outdated
@meroton-benjamin

Copy link
Copy Markdown
Contributor

This bug was identified and fixed in pr #347 as well but as that is a much larger pull request it is likely to need some more time before it is ready to merge. @EdSchouten Any opinion on merging the specific bug fix separately?

Comment thread pkg/blobstore/grpcservers/byte_stream_server.go

@EdSchouten EdSchouten left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once CI is happy.

@snakethatlovesstaticlibs

Copy link
Copy Markdown
Contributor Author

Awesome, thank you @EdSchouten! Looks like the jobs passed

@EdSchouten
EdSchouten merged commit 8ea6e9d into buildbarn:main Aug 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ByteStream ZSTD reads ignore read_offset, corrupting resumed downloads

3 participants