Only append null for the empty list case - #229
Merged
Merged
Conversation
This was referenced Apr 21, 2026
Merged
Merged
isakstenstrom
force-pushed
the
auth-apend-null
branch
from
April 29, 2026 06:29
d98b208 to
0d0380d
Compare
meroton-benjamin
approved these changes
May 4, 2026
isakstenstrom
force-pushed
the
auth-apend-null
branch
from
May 4, 2026 08:53
0d0380d to
2a19735
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is a stacked PR. Please merge #226, #227, #228 first.
In the DB auth privacy layer, we append null in the array of allowed instance names to avoid sending an empty list to the database. Now we instead only append null if it is needed.