Repository navigation
fix(wallet): preserve root across interrupted WAB faucet registration - #892
Merged
Merged
Conversation
ty-everett
marked this pull request as ready for review
October 12, 2026 15:28
ty-everett
requested review from
sirdeggen,
tonesnotes and
ty-everett
as code owners
October 12, 2026 15:28
ty-everett
approved these changes
Oct 12, 2026
BraydenLangley
marked this pull request as draft
October 12, 2026 18:12
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
ty-everett
marked this pull request as ready for review
October 12, 2026 18:42
ty-everett
added a commit
that referenced
this pull request
Oct 12, 2026
8 of 15 tasks
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Program and scope
2ee36d368f43d84ea7a9396cf516131da826fdf2.2ee36d368f43d84ea7a9396cf516131da826fdf2.Impact
Affected source:
@bsv/wallet-toolbox; desktop integration also consumes the pending-registration checkpoint API. The latest commit changes only three test files, with no production, dependency, workflow, threshold, or release metadata changes. The previously prepared wallet/client/mobile 2.15.0 release metadata is not included in this PR head; that original release coordination remains pending and must be resolved before publication.Verification
Fresh local baseline/candidate comparison (2026-10-12)
Isolated Docker WAB/MySQL services, demo authentication, synthetic 2,000,000-sat faucet output, real SQLite wallet signing/storage and reopen, interrupted UMP publication, and a simulated chain that rejects a second distinct redemption:
6493d5f)b175384, production bytes unchanged by latest tests)Both runs reached terminal process exits. Test-owned containers/network/volume were removed. No real phone, account, funds, or external chain broadcast was used. This reproduces the failure mechanism locally; it does not establish Bob's production history or live-chain consensus behavior.
Repeatable regression coverage on latest test bytes
pnpm build,pnpm health:check,pnpm lint,pnpm format:check,pnpm typecheck,pnpm audit:security, changed-test Prettier/oxlint andgit diff --check: pass.Security and dependencies
Release and operations
The testing update is complete. This PR remains draft because the original coordinated release-metadata batch is not pushed; that pending work is separate from this test-only update.
Desktop companion: metanet-client-desktop#69. Publication and deployment are separate actions.