Repository navigation
fix: bootstrap public discovery roots without changing node defaults - #649
Merged
Merged
Conversation
|
ty-everett
marked this pull request as ready for review
September 27, 2026 01:01
ty-everett
deleted the
codex/staging-root-discovery-bootstrap-20260927
branch
September 27, 2026 01:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



A public discovery root can answer direct SHIP requests while default SDK clients cannot find
ls_ship. Ordinary Overlay defaults suppress its discovery-service advertisements, and its wallet advertiser relies on discovering SHIP before synchronizing advertisements. Add explicitDISCOVERY_ROOT=trueso a designated public root registers the default discovery topics/services and bootstraps its advertiser at its own HTTPS origin. Ordinary deployments retain their current defaults and clients retain normal network presets.Program and scope
fc20185d92980bb8fc2329d87c1d0b25c4e8244b.Impact
Overlay Server 2.1.44 is an unpublished image candidate.
DISCOVERY_ROOTdefaults to false. Root mode requires a credential-free HTTPS origin, uses the correct mainnet/testnet/TTN preset, and directs only the advertiser's bootstrap lookups to that origin. Existing signature, admission, propagation, CORS and resource controls remain unchanged.Verification
pnpm build,pnpm typecheck,pnpm lint,pnpm format:checkandpnpm health:checkpassed. Existing maintenance reminders remain visible and were not changed.Security and dependencies
Release and operations
Publish only through protected Infra Release after merged-source acceptance. No schema or wire migration is needed. Operator staging must enable the flag, retain two Ready serving nodes, pass direct and default SHIP/SLAP discovery before handoff, and verify a real UHRP broadcast. Root-mode retirement must verify withdrawal after normal advertisement sync; a restart alone is insufficient. The previous 2.1.43 image preserves data and physical readiness but reintroduces the bootstrap limitation, so it is not a functional recovery claim.
Completion evidence