Repository navigation
Modernize helper package distribution contracts - #354
Conversation
|
ty-everett
left a comment
There was a problem hiding this comment.
Maintainer review on exact head d35bca09736ce31c9cf4b35ed9e6226321301c44: approved in substance. I reviewed the package export/type maps, exact-tarball consumer checks, browser/platform budgets, override removals, Open BSV License v6 artifact enforcement, Sonar remediation, and added branch coverage. All required and advisory checks are green; Codecov patch coverage is 90.146%; Sonar reports 0 new/accepted issues and 0 security hotspots; CodeQL, Dependabot, and secret scanning report 0 open alerts; and there are no unresolved review threads. GitHub does not permit an author to submit an APPROVE review on their own PR, so this COMMENT records the requested ty-everett maintainer approval before admin merge.



Summary
create-bsv-app,@bsv/did,@bsv/did-client,@bsv/simple, and@bsv/templates@bsv/did-clientand@bsv/simplecreate-bsv-appCLI contract testable, including--helpPart of #324.
Progressive quality boundary
This change reduces the repository health baseline from 83 findings to 70 findings (0 errors). It fully standardizes and formats
create-bsv-app, whose test suite was expanded to cover interactive prompting/cancellation, install-manager selection, CLI validation, configuration error paths, and documentation edge cases. The four lower-coverage legacy packages are not mechanically reformatted in this PR: their remaining formatting findings are intentionally retained until tests are expanded, so a formatting-only rewrite cannot conceal untested new-code paths from Codecov or Sonar. Their distribution, type, lint, test, pack, browser, and license contracts are nevertheless upgraded here.Validation
create-bsv-app: format, build, typecheck, lint, 261 tests, coverage, exact pack, and installed CLI checks passed; 97.65% line and 86.41% branch coverage@bsv/did: build, typecheck, lint, 8 tests, coverage, and exact pack checks passed@bsv/did-client: build, typecheck, lint, 6 tests, coverage, exact pack, and Vite/esbuild/UMD browser checks passed@bsv/simple: build, typecheck, lint, 102 tests, coverage, exact pack, and Vite/esbuild browser checks passed@bsv/templates: build, typecheck, lint, 60 tests, coverage, and exact pack checks passedpnpm health:checkpassed with 70 findings and 0 errorspnpm audit:securitypassed with no known vulnerabilitiespnpm license:pack-checkpassed for all 30 public tarballsd35bca097Measured browser artifacts remain within explicit raw/gzip/Brotli budgets: