Skip to content

Harden SDK wire decoding and resolve CodeQL findings - #353

Merged
ty-everett merged 1 commit into
mainfrom
codex/program-wave-1c-codeql-followup
Jul 26, 2026
Merged

ty-everett merged 1 commit into
mainfrom
codex/program-wave-1c-codeql-followup

Conversation

@ty-everett

Copy link
Copy Markdown
Collaborator

Summary

  • construct wallet-wire records through Map and Object.fromEntries instead of untrusted computed property writes
  • reject __proto__ and enforce the existing 1–50 UTF-8-byte certificate field-name contract at the wire boundary
  • express deterministic Base58 remainders as quotient subtraction so CodeQL no longer treats conversion math as biased random sampling
  • add adversarial wallet-wire tests and Base58 boundary round-trip coverage

This is the Wave 1c security follow-up in #324. It resolves current CodeQL alerts #205–#211 in code; no alert is dismissed or suppressed.

Validation

  • SDK lint: pass (no errors; pre-existing warnings only)
  • SDK build: pass (TypeScript dual package and UMD)
  • focused tests: 133 passed
  • full SDK suite: 5,715 passed, 3 skipped, 1 snapshot
  • full SDK coverage: 92.04% lines / 82.93% branches
  • repository health: pass (37 projects; existing 83 findings and 11 exceptions; 0 control errors)
  • security audit: no known high-severity vulnerabilities
  • version and codegen checks: pass; 9 generated files current
  • conformance: 6,650 vectors across 74 files, 0 errors
  • license policy: all 46 manifests use Open BSV License v6; all 30 public package tarballs contain the canonical license

Compatibility

Ordinary wallet arguments and public service behavior are unchanged. This PR does not alter CORS/CSP defaults, publishing, versions, or deployment behavior.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ty-everett ty-everett left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED IN SUBSTANCE by ty-everett for admin merge.

Reviewed exact head 33e236d7f6f88b695a293e67df46daefd7ebc326 against Wave 1c of #324. The five wallet-wire findings are removed structurally via safe entry construction plus trust-boundary validation, and the two Base58 findings are removed through equivalent deterministic quotient/remainder arithmetic. Adversarial and regression coverage is present.

Evidence reviewed:

  • all 31 exact-head checks are successful
  • CodeQL JavaScript/TypeScript analysis is successful; the PR alert API returns 0 open alerts
  • SonarCloud quality gate passes with 0 open/confirmed issues and 0 security hotspots
  • Codecov reports every modified coverable line covered
  • no dependency-review or Socket findings
  • 0 unresolved review threads and no requested changes

GitHub prohibits an author from formally approving their own PR. This review records the required maintainer approval in substance; the admin merge is deliberate and authorized.

@ty-everett
ty-everett merged commit 6ebeb71 into main Jul 26, 2026
31 checks passed
@ty-everett
ty-everett deleted the codex/program-wave-1c-codeql-followup branch July 26, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant