Repository navigation
Harden SDK wire decoding and resolve CodeQL findings - #353
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ty-everett
left a comment
There was a problem hiding this comment.
APPROVED IN SUBSTANCE by ty-everett for admin merge.
Reviewed exact head 33e236d7f6f88b695a293e67df46daefd7ebc326 against Wave 1c of #324. The five wallet-wire findings are removed structurally via safe entry construction plus trust-boundary validation, and the two Base58 findings are removed through equivalent deterministic quotient/remainder arithmetic. Adversarial and regression coverage is present.
Evidence reviewed:
- all 31 exact-head checks are successful
- CodeQL JavaScript/TypeScript analysis is successful; the PR alert API returns 0 open alerts
- SonarCloud quality gate passes with 0 open/confirmed issues and 0 security hotspots
- Codecov reports every modified coverable line covered
- no dependency-review or Socket findings
- 0 unresolved review threads and no requested changes
GitHub prohibits an author from formally approving their own PR. This review records the required maintainer approval in substance; the admin merge is deliberate and authorized.



Summary
MapandObject.fromEntriesinstead of untrusted computed property writes__proto__and enforce the existing 1–50 UTF-8-byte certificate field-name contract at the wire boundaryThis is the Wave 1c security follow-up in #324. It resolves current CodeQL alerts #205–#211 in code; no alert is dismissed or suppressed.
Validation
Compatibility
Ordinary wallet arguments and public service behavior are unchanged. This PR does not alter CORS/CSP defaults, publishing, versions, or deployment behavior.