Skip to content

Deduplicate identity search by best matching certificate - #19

Closed
BraydenLangley wants to merge 2 commits into
masterfrom
codex/dedupe-identity-search-20261008
Closed

BraydenLangley wants to merge 2 commits into
masterfrom
codex/dedupe-identity-search-20261008

Conversation

@BraydenLangley

@BraydenLangley BraydenLangley commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Return one result per identity key by default from both IdentitySearchField and useIdentitySearch.
  • Keep distinct keys even when their display names match. For duplicate certificates on one key, prefer the presentation whose name and certificate field type best match the query; keep the first on ties.
  • Preserve the existing deduplicate={false} component option and add the same option to the headless hook.
  • Bump to 2.0.1 because a merge to master runs the npm publication workflow.

Validation

  • npm run lint:ci
  • npm run typecheck
  • npm run build
  • npm run test:coverage (37 tests)
  • npm run test:consumer (packed React 18/MUI 5 consumer)
  • npm audit --audit-level=high
  • Linked this worktree into the metanet-client-desktop branch and passed its 273 tests, lint, typecheck, and production build.

The desktop Send & Receive picker has a separate search implementation; its matching fix is in the companion desktop branch.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utils/dedupeIdentities.ts 92.00% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@BraydenLangley
BraydenLangley marked this pull request as draft October 8, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant