Repository navigation
ci: scan against Go 1.27.2 and bump golang.org/x/net to v0.60.0 - #364
Merged
Merged
Conversation
govulncheck and OSV-Scanner report 13 stdlib@v1.27.1 vulnerabilities, all fixed in Go 1.27.2, so the Security Scans job fails on every PR until the govulncheck toolchain pin moves to 1.27.2. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted version bump is correctly consumed by the security scan workflow.
0 open findings
What changed in this PR
Updates security scanning to use the patched Go 1.27.2 toolchain.
Changes:
- Bumps
GOVULNCHECK_GO_VERSIONfrom 1.27.1 to 1.27.2.
| File | Description |
|---|---|
.github/env/00-core.env |
Updates the Go version used by vulnerability scans. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The five govulncheck findings left after moving to Go 1.27.2 are all in golang.org/x/net@v0.59.0 and fixed in v0.60.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mrz1836
disabled auto-merge
October 9, 2026 01:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security Scansfails on every open PR (e.g. #362, #363). Two causes, both fixed here:stdlib@v1.27.1, all fixed in Go 1.27.2..github/env/00-core.envpinnedGOVULNCHECK_GO_VERSION=1.27.1; this moves it to 1.27.2.GO_PRIMARY_VERSIONis already1.27.x, so builds and tests pick up the patch release on their own.golang.org/x/net@v0.59.0, fixed in v0.60.0. Bumped ingo.mod.Test plan
go build ./...,go vet, and the merkleservice / api_server / teranode tests pass locally on the bumpSecurity Scansjob on this PR goes green🤖 Generated with Claude Code