Added missing tests and fixed broken adapters - #67
Open
angelo0000 wants to merge 1 commit into
Open
Conversation
…age. Also made fixes to the memory adapter because it would not pass the existing tests. The dom adapter was missing the exists api method and its remove implementation was not adhering to the api of passing a key or array to remove.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added additional tests to prove the index stays in sync with the storage. Also made fixes to the memory adapter because it would not pass the existing tests. The dom adapter was missing the exists api method and its remove implementation was not adhering to the api of passing a key or array to remove.