Code linting and full compliancy - #210
Open
zenoamaro wants to merge 32 commits into
Open
Conversation
|
thanks for the work, man! i guess it might make sense to put this on a development branch for a v2 ov lawnchair ... i'll think of something. can't promise when i'll have the time to go through it, but a big thanks already! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a lint step over
src/*using jshint.I've tried to replicate the current project style (taken from the main module, rather than adapters), the NPM style, and @brianleroux's own comments in #208, producing a
.jshintrcin the project root.Here is a summary of changes:
testduringdefaultandrelease.Notes:
master(I don't have a couchdb available), but those that do still pass in this branch.It can still be improved. Code style in adapters still varies wildly, for example, and there are opportunities for optimization and deduplication here and there. But they are out of scope for this PR, which is supposed to leave everything unchanged.
There is eslint too, which has different options for forcing code style, and jscs which is focused on enforcing code style only, but jshint is the safe choice so I picked that.