Skip to content

Fix query interpolation #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruiwen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix query interpolation #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ddb78
Interpolating by str.replace() instead of string splitting
ruiwen Jan 12, 2013
ed3d272
Args may be of unknown length, but call the callback nonetheless
ruiwen Jan 12, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/plugins/query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,16 @@
Lawnchair.plugin((function(){
//
var interpolate = function(template, args) {
var parts = template.split('?').filter(function(i) { return i != ''})
, query = ''

for (var i = 0, l = parts.length; i < l; i++) {
query += parts[i] + args[i]
}
return query
query = template.replace(/\?/g, function() {
var item = args.shift();
if(typeof item == "string") {
item = "'" + item + "'";
}
return item;
});

return query;
}

var sorter = function(p) {
Expand Down Expand Up @@ -44,7 +47,7 @@ Lawnchair.plugin((function(){
// overwrite working results
this.__results = r
// callback / chain
if (args.length === 1) this.fn(this.name, last).call(this, this.__results)
if (args.length) this.fn(this.name, last).call(this, this.__results)
return this
},

Expand Down