Skip to content

[3.x] Remove naughty use of transitive ci-info dependency #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnapoli merged 1 commit into from
Apr 28, 2026
+34 −5
Merged

[3.x] Remove naughty use of transitive ci-info dependency #2107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 34 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,39 @@ const {warnIfUsingSecretsWithoutTheBrefDependency} = require('./plugin/secrets')
const fs = require('fs');
const path = require('path');

const ciEnvironmentVariables = [
'BUILD_ID', // Jenkins, Cloudbees
'BUILD_NUMBER', // Jenkins, TeamCity
'CI', // Travis CI, CircleCI, GitLab CI, etc.
'CI_APP_ID', // Appflow
'CI_BUILD_ID', // Appflow
'CI_BUILD_NUMBER', // Appflow
'CI_NAME', // Codeship and others
'CONTINUOUS_INTEGRATION', // Travis CI, Cirrus CI
'RUN_ID', // TaskCluster, dsari
'GITHUB_ACTIONS',
'GITLAB_CI',
'CIRCLECI',
'TRAVIS',
'APPVEYOR',
'BUILDKITE',
'CODEBUILD_BUILD_ARN',
'TF_BUILD', // Azure Pipelines
'TEAMCITY_VERSION',
'JENKINS_URL',
'BITBUCKET_COMMIT',
'DRONE',
'NETLIFY',
'VERCEL',
'CF_PAGES', // Cloudflare Pages
'RENDER',
'BITRISE_IO',
];

function isCiEnvironment(env) {
return env.CI !== 'false' && ciEnvironmentVariables.some((name) => Boolean(env[name]));
}

// Disable `sls` promoting the Serverless Console because it's not compatible with PHP, it's tripping users up
if (!process.env.SLS_NOTIFICATIONS_MODE) {
process.env.SLS_NOTIFICATIONS_MODE = 'upgrades-only';
Expand Down Expand Up @@ -315,9 +348,6 @@ class ServerlessPlugin {
/** @type {{ get: (string) => string }} */
// @ts-ignore
const userConfig = require.main.require('@serverless/utils/config');
/** @type {typeof import('ci-info')} */
// @ts-ignore
const ci = require.main.require('ci-info');

let command = 'unknown';
if (this.serverless.processedInput && this.serverless.processedInput.commands) {
Expand All @@ -335,7 +365,7 @@ class ServerlessPlugin {
cli: 'sls',
v: 3, // Bref version
c: command,
ci: ci.isCI,
ci: isCiEnvironment(process.env),
install: userConfig.get('meta.created_at'),
uid: userConfig.get('frameworkId'), // anonymous user ID created by the Serverless Framework
tz: timezone,
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
},
"devDependencies": {
"@serverless/typescript": "^3.30.1",
"@types/ci-info": "^3.1.0",
"@types/node": "^20.3.1",
"@typescript-eslint/eslint-plugin": "^5.59.11",
"@typescript-eslint/parser": "^5.59.11",
Expand Down
Loading