fix(dynamodb): reject empty sets and non-string map keys in TypeSerializer#4741
Open
r266-tech wants to merge 1 commit intoboto:developfrom
Open
fix(dynamodb): reject empty sets and non-string map keys in TypeSerializer#4741r266-tech wants to merge 1 commit intoboto:developfrom
r266-tech wants to merge 1 commit intoboto:developfrom
Conversation
…lizer
- _is_type_set now checks len(value) > 0 to prevent vacuous truth
matching empty sets, which produce invalid {'NS': []} that DynamoDB
rejects (fixes boto#4738)
- _serialize_m now validates all map keys are strings before
serialization, raising TypeError for non-string keys that would
produce confusing errors later (fixes boto#4739)
Both fixes raise TypeError with clear messages at serialization time
rather than letting invalid data reach the DynamoDB API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Changes
boto3/dynamodb/types.py
tests/unit/dynamodb/test_types.py
Testing
All 41 tests in test_types.py pass.