-
Notifications
You must be signed in to change notification settings - Fork 5
BPIP11: Account-free exchanges #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zajck
wants to merge
4
commits into
bosonprotocol:main
Choose a base branch
from
zajck:accountless-exchange
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| --- | ||
| bpip: 11 | ||
| title: Account-free exchanges | ||
| authors: Klemen Zajc | ||
| discussions-to: https://github.com/bosonprotocol/BPIPs/discussions/40 | ||
| status: Draft | ||
| created: 2025-07-03 | ||
| --- | ||
|
|
||
| ## Abstract | ||
| This proposal describes an option to do the use the Boson Protocol without an explicit account creation. | ||
|
|
||
| ## Motivation | ||
| Before the seller can create an offer, they must create a protocol account. This has some features that are used by some sellers: | ||
| 1. it allows better role management via admin, assistant and treasury, | ||
| 2. it allows the seller to attach metadata URI, | ||
| 3. it preserves the account history even if the wallet addresses are change. | ||
|
|
||
| While this are a good features, the seller creation requires a setup, which presents a friction and might be unnecessary for certain sellers. | ||
|
|
||
| In this BPIP we propose to change the account management system to allow the sellers to create an offer and execute exchange without an explicit account creation. When BPIP9 and BPIP10 are implemented, they will even increase the demand for account-free exchanges. | ||
|
|
||
| The protocol can still use internal ids for tracking; however, all account are created implicitly, similarly as it is already done for buyer accounts. | ||
|
|
||
| Similarly, the dispute resolvers account could be implicitly created when they are added to the offer. | ||
|
|
||
| This BPIP does not remove the existing account management. Sellers that want to use the advanced accounts can continue using their existing accounts and new sellers can create new accounts. | ||
|
|
||
| ## Specification | ||
| TBD | ||
|
|
||
| ## Rationale | ||
| TBD | ||
|
|
||
| ## Backward compatibility | ||
| This specification does not break backward compatibility. | ||
|
|
||
| ## Implementation | ||
| * Create offer | ||
| * If seller id is provided, check that the caller is the assistant | ||
| * If seller id is not provided, create an account with all roles managed by the caller | ||
| * Allow providing dispute resolver address instead of dispute resolver id. | ||
| * If address belongs to an existing DR account, use its id | ||
| * If address does not belong to an existing DR, create a new DR account with all roles managed by the address | ||
|
|
||
| ### Security considerations | ||
|
|
||
| This does not break protocol guarantees or lower the trust, since already in the existing system, both seller and buyer had to agree on all offer parameters in order to go into exchange. | ||
|
|
||
| ## Copyright waiver & license | ||
| Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could re-write this since 9 and 10 are final now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done