Fix/fmt tfvars#373
Open
amincheloh wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundle exec rspecto verify this)Summary
terraspace fmtrenames source files containing ERB (<%) to*.skipbefore runningterraform fmt, then restores them. The skip glob only matched*.{tf,skip}, so ERB.tfvarsfiles were missed. With-recursive,terraform fmtdescends into thetfvars/subfolder and errors on them:Error: Invalid character on tfvars/base.tfvars line 1:
1: some_var = <%= output('other-stack.x') %>
Fix: add
tfvarsto the glob so ERB.tfvarsfiles are skipped like ERB.tffiles. Also documents the-recursiveoption in thefmthelp text.Context
terraform fmtis non-recursive by default, so.tfvarsintfvars/are only reached with-recursive, where the missing skip handling surfaced as a hard error. One-line change inlib/terraspace/cli/fmt/runner.rb:How to Test
With an ERB .tfvars in a stack's tfvars/ subfolder, terraspace fmt -recursive errors before this change (exit 2) and succeeds after (exit 0, ERB tfvars left intact). Specs:
bundle exec rspec spec/terraspace/cli/fmt/runner_spec.rb
Version Changes
Patch — backwards-compatible bug fix.