Skip to content

⚡ Bolt: [performance improvement] #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobdivx wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-08-24 - Database Aggregation
**Learning:** Fetching full tables into JS memory and using `.filter().length` causes OOM exceptions and severe CPU bottlenecks at scale.
**Action:** Use Astro DB (Drizzle) aggregations like `count()`, `inArray()`, and `gte()` directly in the database queries instead.
37 changes: 15 additions & 22 deletions src/pages/api/dashboard-kpis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ function countRunningSessions(sessions: unknown[]): number {
}).length;
}

function isOpenQueueStatus(st: string): boolean {
const s = String(st).toLowerCase();
return s === 'open' || s === 'in_progress';
}

export const GET: APIRoute = async () => {
const base = {
Expand All @@ -42,30 +38,27 @@ export const GET: APIRoute = async () => {
};

try {
const { db, Project, AgentTask, Request, AgentAppIssue, AgentDependencyRequest, eq } =
const { db, Project, AgentTask, Request, AgentAppIssue, AgentDependencyRequest, eq, count, inArray, gte } =
await loadAstroDb();
const today = new Date();
today.setHours(0, 0, 0, 0);

const [projects, tasksAll, openRequests, issuesAll, depsAll] = await Promise.all([
db.select().from(Project),
db.select().from(AgentTask),
db.select().from(Request).where(eq(Request.status, 'pending')),
db.select().from(AgentAppIssue),
db.select().from(AgentDependencyRequest),
// ⚡ Bolt Optimization: Use DB aggregation (count, gte, inArray) instead of fetching full tables into memory
const [projectsRes, tasksAllRes, tasksTodayRes, openReqsRes, issuesRes, depsRes] = await Promise.all([
db.select({ value: count() }).from(Project),
db.select({ value: count() }).from(AgentTask),
db.select({ value: count() }).from(AgentTask).where(gte(AgentTask.createdAt, today)),
db.select({ value: count() }).from(Request).where(eq(Request.status, 'pending')),
db.select({ value: count() }).from(AgentAppIssue).where(inArray(AgentAppIssue.status, ['open', 'in_progress'])),
db.select({ value: count() }).from(AgentDependencyRequest).where(inArray(AgentDependencyRequest.status, ['open', 'in_progress'])),
]);

const tasksTodayCount = tasksAll.filter((t) => {
const d = t.createdAt instanceof Date ? t.createdAt : new Date(t.createdAt as Date);
return d >= today;
}).length;

base.projectCount = projects.length;
base.tasksTotal = tasksAll.length;
base.tasksToday = tasksTodayCount;
base.openRequests = openRequests.length;
base.openAppIssues = issuesAll.filter((r) => isOpenQueueStatus(String(r.status))).length;
base.openDependencyRequests = depsAll.filter((r) => isOpenQueueStatus(String(r.status))).length;
base.projectCount = projectsRes[0]?.value || 0;
base.tasksTotal = tasksAllRes[0]?.value || 0;
base.tasksToday = tasksTodayRes[0]?.value || 0;
base.openRequests = openReqsRes[0]?.value || 0;
base.openAppIssues = issuesRes[0]?.value || 0;
base.openDependencyRequests = depsRes[0]?.value || 0;
} catch (e) {
const msg = e instanceof Error ? e.message : String(e);
base.dbError = msg;
Expand Down