Release/2.x.x - #19
Conversation
16 add support percona 8.0 installation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| - name: Touch a /var/run/mysqld/mysqld.pid file | ||
| ansible.builtin.file: | ||
| path: /var/run/mysqld/mysqld.pid | ||
| state: touch | ||
| mode: u=rw,g=r,o=r | ||
| owner: mysql | ||
| group: mysql |
There was a problem hiding this comment.
Guard creation of mysqld pid file
The new task touches /var/run/mysqld/mysqld.pid unconditionally. On a fresh installation the /var/run/mysqld runtime directory is created by systemd only when the service starts, so this task will fail with “No such file or directory” before MySQL has ever been started. That means the role now errors out on first run for hosts where the directory hasn’t been created yet. Consider ensuring the directory exists (or using the mysql_pid_file variable’s directory) before touching the file or moving the task behind the service start.
Useful? React with 👍 / 👎.
b2fbe60 to
654fb24
Compare
654fb24 to
4228a4d
Compare
No description provided.