Skip to content

Release/2.x.x - #19

Merged
g0blin79 merged 8 commits into
mainfrom
release/2.x.x
Oct 14, 2025
Merged

Release/2.x.x#19
g0blin79 merged 8 commits into
mainfrom
release/2.x.x

Conversation

@g0blin79

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment thread tasks/configure.yml Outdated
Comment on lines +30 to +36
- name: Touch a /var/run/mysqld/mysqld.pid file
ansible.builtin.file:
path: /var/run/mysqld/mysqld.pid
state: touch
mode: u=rw,g=r,o=r
owner: mysql
group: mysql

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard creation of mysqld pid file

The new task touches /var/run/mysqld/mysqld.pid unconditionally. On a fresh installation the /var/run/mysqld runtime directory is created by systemd only when the service starts, so this task will fail with “No such file or directory” before MySQL has ever been started. That means the role now errors out on first run for hosts where the directory hasn’t been created yet. Consider ensuring the directory exists (or using the mysql_pid_file variable’s directory) before touching the file or moving the task behind the service start.

Useful? React with 👍 / 👎.

@g0blin79
g0blin79 force-pushed the release/2.x.x branch 7 times, most recently from b2fbe60 to 654fb24 Compare October 14, 2025 14:43
@g0blin79
g0blin79 merged commit 7969392 into main Oct 14, 2025
4 checks passed
@g0blin79 g0blin79 linked an issue Oct 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Percona 8 installation

2 participants