Repository navigation
Support repeated GQL node variables with SameAs - #352
Merged
kellrott merged 5 commits intoSep 30, 2026
Merged
Conversation
Co-authored-by: kellrott <113868+kellrott@users.noreply.github.com>
Co-authored-by: kellrott <113868+kellrott@users.noreply.github.com>
Co-authored-by: kellrott <113868+kellrott@users.noreply.github.com>
Copilot
AI
changed the title
Add SameAs support for repeated GQL variables
Support repeated GQL node variables with SameAs
Sep 30, 2026
kellrott
requested changes
Sep 30, 2026
| for _, gs := range stmts { | ||
| switch gs.GetStatement().(type) { | ||
| case *gripql.GraphStatement_Jump, *gripql.GraphStatement_Set, | ||
| *gripql.GraphStatement_SameAs, |
Member
There was a problem hiding this comment.
Rather then leave it as unsupported op, it should be implemented into the mongo pipeline compiler
Author
There was a problem hiding this comment.
Implemented native Mongo pipeline compilation for SameAs, including binding/type validation and mark preservation. Commit: 2e3c30f.
Member
|
@copilot can you implement SameAs in the mongo cross compiler, rather then leaving it as an unsupported op? |
Co-authored-by: kellrott <113868+kellrott@users.noreply.github.com>
Author
|
Co-authored-by: kellrott <113868+kellrott@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated node variables in GQL patterns must constrain later occurrences to the same graph element. GripQL now provides
SameAsfor that identity check; repeated edge variables remain explicitly unsupported until edge bindings are available.SameAswithout overwriting their original binding.