makes-pmac-a-pmactrajectorytriggerlogic-class-reference#1223
Merged
gkalua merged 3 commits intoMar 12, 2026
Conversation
shihab-dls
reviewed
Mar 11, 2026
| ): | ||
| def __init__(self, pmac: PmacIO, name: str = "") -> None: | ||
| self.pmac = pmac | ||
| self._pmac_ref = Reference(pmac) |
Contributor
There was a problem hiding this comment.
Can we just do:
Suggested change
| self._pmac_ref = Reference(pmac) | |
| self.pmac_ref = Reference(pmac) |
and remove the @property? Then everywhere that references .pmac should use .pmac_ref().
shihab-dls
approved these changes
Mar 11, 2026
coretl
approved these changes
Mar 11, 2026
gkalua
deleted the
Make-Pmac-a-PmacTrajectoryTriggerLogic-class-reference
branch
coretl
pushed a commit
that referenced
this pull request
Mar 16, 2026
* makes-pmac-a-pmactrajectorytriggerlogic-class-reference * Addresses comments --------- Co-authored-by: gkalua <jyv15736@pc0139.cs.diamond.ac.uk> Co-authored-by: Shihab S <162436767+shihab-dls@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addreses DiamondLightSource/dodal#1952