Skip to content

Fix setup peripherals#3915

Open
patrickelectric wants to merge 12 commits intobluerobotics:masterfrom
patrickelectric:fix-setup-peripherals
Open

Fix setup peripherals#3915
patrickelectric wants to merge 12 commits intobluerobotics:masterfrom
patrickelectric:fix-setup-peripherals

Conversation

@patrickelectric
Copy link
Copy Markdown
Member

@patrickelectric patrickelectric commented Apr 30, 2026

image

Fix #3031

Summary by Sourcery

Improve vehicle setup overview UI for peripherals and sensors.

New Features:

  • Show status messages when ping sensors, lights, or video devices are not detected or configured.
  • Add descriptive icons to vehicle setup overview cards for peripherals, sensors, power, and vehicle info.

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…cards

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
… configured

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…is detected

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
… if video device is not configured or detected

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The empty-state messages for peripherals are inconsistent (Not detected, Not configured, Not detected or configured); consider standardizing the wording so users get a clear, uniform signal across Ping, Lights, and Video.
  • The repeated pattern of <v-card-title class="align-center"><v-icon left>…</v-icon> Title</v-card-title> across multiple overview components could be factored into a small shared header component to reduce duplication and keep the look-and-feel consistent.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The empty-state messages for peripherals are inconsistent (`Not detected`, `Not configured`, `Not detected or configured`); consider standardizing the wording so users get a clear, uniform signal across Ping, Lights, and Video.
- The repeated pattern of `<v-card-title class="align-center"><v-icon left>…</v-icon> Title</v-card-title>` across multiple overview components could be factored into a small shared header component to reduce duplication and keep the look-and-feel consistent.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Adds Material Design icons to the eight vehicle-setup overview cards (Leak, Lights, Onboard Sensors, Ping, Power, Vehicle, Video, Gripper) and introduces empty-state messages for Lights ("Not configured"), Ping ("Not detected"), and Video ("Not detected or configured"). Also normalises PingInfo's title from justify-center to align-center to match the rest of the cards.

The empty-state copy differs intentionally per card (configured vs. detected vs. either), reflecting how each subsystem is actually populated — SERVO_FUNCTION parameters for Lights, runtime probe for Ping, both for Video — so the wording is appropriate. Cards that always have data to show (Leak, Onboard Sensors, Power, Vehicle) correctly only get the icon. gripper.vue already had its own v-if="gripper === null" empty branch, so no change there beyond the icon.

Nothing to comment, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

core: frontend: vehicle-setup: add icons to peripheral cards

2 participants