Fix setup peripherals#3915
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…cards Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
… configured Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
…is detected Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
… if video device is not configured or detected Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The empty-state messages for peripherals are inconsistent (
Not detected,Not configured,Not detected or configured); consider standardizing the wording so users get a clear, uniform signal across Ping, Lights, and Video. - The repeated pattern of
<v-card-title class="align-center"><v-icon left>…</v-icon> Title</v-card-title>across multiple overview components could be factored into a small shared header component to reduce duplication and keep the look-and-feel consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The empty-state messages for peripherals are inconsistent (`Not detected`, `Not configured`, `Not detected or configured`); consider standardizing the wording so users get a clear, uniform signal across Ping, Lights, and Video.
- The repeated pattern of `<v-card-title class="align-center"><v-icon left>…</v-icon> Title</v-card-title>` across multiple overview components could be factored into a small shared header component to reduce duplication and keep the look-and-feel consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Automated PR Review0. Summary
Adds Material Design icons to the eight vehicle-setup overview cards (Leak, Lights, Onboard Sensors, Ping, Power, Vehicle, Video, Gripper) and introduces empty-state messages for Lights ("Not configured"), Ping ("Not detected"), and Video ("Not detected or configured"). Also normalises The empty-state copy differs intentionally per card (configured vs. detected vs. either), reflecting how each subsystem is actually populated — SERVO_FUNCTION parameters for Lights, runtime probe for Ping, both for Video — so the wording is appropriate. Cards that always have data to show (Leak, Onboard Sensors, Power, Vehicle) correctly only get the icon. Nothing to comment, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
Fix #3031
Summary by Sourcery
Improve vehicle setup overview UI for peripherals and sensors.
New Features: