Skip to content

frontend: views: ExtensionManagerView: center extension manager tabs #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicoschmdt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

frontend: views: ExtensionManagerView: center extension manager tabs #3869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions core/frontend/src/views/ExtensionManagerView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,11 +215,12 @@
:extension-identifier="selected_log_extension_identifier"
:extension-name="selected_log_extension_name"
/>
<v-toolbar>
<v-spacer />
<v-toolbar class="extension-toolbar">
<v-tabs
v-model="tab"
fixed-tabs
show-arrows
class="extension-tabs"
>
<v-tab key="0" href="#0" class="tab-text">
<v-icon class="mr-3">
Comment on lines +218 to 226
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Absolute positioning of the settings button may overlap the tabs without reserving horizontal space.

With .extension-toolbar-settings absolutely positioned, the tabs can extend underneath it because the toolbar no longer reserves horizontal space for the button. Around the breakpoint this can cause the settings icon to overlap tab labels or arrows.

Consider adding right padding or a max-width on .extension-toolbar (or similar layout change) so the tabs never render under the settings icon.

Expand All @@ -240,11 +241,10 @@
Installed
</v-tab>
</v-tabs>
<v-spacer />
<v-btn
v-tooltip="'Settings'"
icon
hide-details="auto"
class="extension-toolbar-settings"
@click="show_settings = true"
>
<v-icon>mdi-cog</v-icon>
Expand Down Expand Up @@ -1210,6 +1210,28 @@ pre.logs {
white-space: nowrap !important;
}

.extension-toolbar {
position: relative;
}

.extension-tabs {
flex: 1 1 0;
min-width: 0;
}

.extension-toolbar-settings {
flex-shrink: 0;
}

@media (min-width: 900px) {
.extension-toolbar-settings {
position: absolute;
right: 16px;
top: 50%;
transform: translateY(-50%);
}
}

.scrollable-content {
max-height: calc(80vh - 64px);
overflow-y: auto;
Expand Down
Loading