Skip to content

fix: Always check if file exists when playing from cache#1980

Open
Rexios80 wants to merge 2 commits intobluefireteam:mainfrom
Rexios80:feature/always-check-file-exists
Open

fix: Always check if file exists when playing from cache#1980
Rexios80 wants to merge 2 commits intobluefireteam:mainfrom
Rexios80:feature/always-check-file-exists

Conversation

@Rexios80
Copy link
Copy Markdown

Description

The caching issue that was fixed on Android also exists on iOS. This PR removes the platform check so that the file existence is validated on all platforms.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in [example].

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Copy Markdown
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants