Skip to content

cdb2api: Updates for amalgamation build#6080

Merged
akshatsikarwar merged 1 commit into
bloomberg:mainfrom
akshatsikarwar:cdb2api-amalgamation
Jul 23, 2026
Merged

cdb2api: Updates for amalgamation build#6080
akshatsikarwar merged 1 commit into
bloomberg:mainfrom
akshatsikarwar:cdb2api-amalgamation

Conversation

@akshatsikarwar

@akshatsikarwar akshatsikarwar commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

/plugin-branch cdb2api-amalgamation

@akshatsikarwar

akshatsikarwar commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

There are no real code changes here, other than introducing cdb2_register_event_varg so wrapper can dispatch variadic arguments (ported from older version of the API.) All other changes just introduce static modifier so symbols are not visible outside of cdb2api TU. Existing tests are sufficient to validate changes in this PR.

@akshatsikarwar
akshatsikarwar marked this pull request as draft July 21, 2026 20:35
@akshatsikarwar
akshatsikarwar force-pushed the cdb2api-amalgamation branch 2 times, most recently from f625d1c to cffa97d Compare July 21, 2026 20:57
roborivers
roborivers suggested changes Jul 21, 2026
View reviewed changes

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

roborivers
roborivers suggested changes Jul 21, 2026
View reviewed changes

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**

roborivers
roborivers suggested changes Jul 21, 2026
View reviewed changes

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
sc_truncate [db unavailable at finish]
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
truncatesc_offline_generated [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
sql_logfill_autodisable [timeout]

roborivers
roborivers suggested changes Jul 22, 2026
View reviewed changes

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

@akshatsikarwar
akshatsikarwar marked this pull request as ready for review July 22, 2026 20:05
roborivers
roborivers suggested changes Jul 22, 2026
View reviewed changes

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
manual_partition
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**

@akshatsikarwar
cdb2api: Updates for amalgamation build
cc862dd 
Signed-off-by: Akshat Sikarwar <asikarwar1@bloomberg.net>
roborivers
roborivers suggested changes Jul 23, 2026
View reviewed changes

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**

@akshatsikarwar
akshatsikarwar merged commit 6765b49 into bloomberg:main Jul 23, 2026
3 of 4 checks passed
@akshatsikarwar
akshatsikarwar deleted the cdb2api-amalgamation branch July 23, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chands10 chands10 chands10 approved these changes
+1 more reviewer
@roborivers roborivers roborivers requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akshatsikarwar @roborivers @chands10