Skip to content

newsql_get_snapshot: fall back to stored snapshot on ha-retry #6079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markhannum wants to merge 1 commit into
base: main
Choose a base branch
from
Open

newsql_get_snapshot: fall back to stored snapshot on ha-retry #6079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions plugins/newsql/newsql.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,6 +1406,13 @@ static int newsql_get_snapshot(struct sqlclntstate *clnt, int *file,
*file = sqlquery->snapshot_info->file;
*offset = sqlquery->snapshot_info->offset;
}
/* On ha-retry, statements after BEGIN (e.g. INSERT) carry no
* snapshot_info in their sqlquery. Fall back to the snapshot stored
* on the clnt during BEGIN handling, just as fill_snapinfo does. */
if (*file == 0 && clnt->is_hasql_retry && clnt->snapshot_file) {
*file = clnt->snapshot_file;
*offset = clnt->snapshot_offset;
}
return 0;
}

Expand Down
Loading