fdb: honor LOCAL_ prefix when creating a new fdb#6078
Open
dorinhogea wants to merge 1 commit into
Open
Conversation
Set fdb->local from a LOCAL_ prefix at creation time so old code using LOCAL_ works even when foreign_db_resolve_local is not set. Existing fdbs still ignore the prefix and spew the deprecation warning. Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
roborivers
suggested changes
Jul 21, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
sc_resume_logicalsc_generated **quarantined**
ssl_san
sc_parallel_logicalsc_generated
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_dbname
ssl_prefer
sc_downgrade [timeout] **quarantined**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set fdb->local from a LOCAL_ prefix at creation time so old code using LOCAL_ works even when foreign_db_resolve_local is not set. Existing fdbs still ignore the prefix and spew the deprecation warning.
Change in semantics: if first request to reach a remote fdb uses LOCAL_, all further access will go to local fdb and ignore missing prefixes.