Fixing reqlog queuetime for verify-retry#6070
Open
riverszhang89 wants to merge 1 commit into
Open
Conversation
`clnt->enque_timeus` is calculated exactly once per `thdpool_enqueue`, whereas `clnt->deque_timeus` is re-calculated on each `sqlengine_work_appsock` call. This causes inline retries from a verify error to inflate reqlog's queuetime (`queuetime = deque_timeus - enque_timeus`). This patch moves the `deque_timeus` stamping to `sqlengine_work_appsock_pp`, so that it's truly the time when dequeue from the thread pool happens. Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
Contributor
Author
|
#5962 would also work around the inflated reqlog queuetime from verify-retry. Regardless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clnt->enque_timeusis calculated exactly once perthdpool_enqueue, whereasclnt->deque_timeusis re-calculated on eachsqlengine_work_appsockcall. This causes inline retries from a verify error to inflate reqlog's queuetime (queuetime = deque_timeus - enque_timeus).This patch moves the
deque_timeusstamping tosqlengine_work_appsock_pp, so that it's truly the time when dequeue from the thread pool happens.