Skip to content

feat: offchain vote ens resolution #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeonardoVieira1630 merged 1 commit into from
Apr 24, 2026
+5 −4
Merged

feat: offchain vote ens resolution #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/dispatcher/src/services/triggers/offchain-vote-cast-trigger.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ function buildExpectedMessage(vote: OffchainVoteWithDaoId): string {
: offchainVoteCastMessages.withoutReason;

return replacePlaceholders(template, {
address: vote.voter,
daoId: vote.daoId,
proposalTitle: vote.proposalTitle,
...(hasReason && { reason: vote.reason! }),
Expand All @@ -89,7 +88,7 @@ function buildExpectedPayload(vote: OffchainVoteWithDaoId): NotificationPayload
channelUserId: STUB_USER.channel_user_id,
message: buildExpectedMessage(vote),
bot_token: undefined,
metadata: undefined,
metadata: { addresses: { address: vote.voter } },
};
}

Expand Down
4 changes: 2 additions & 2 deletions apps/dispatcher/src/services/triggers/offchain-vote-cast-trigger.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,8 @@ export class OffchainVoteCastTriggerHandler extends BaseTriggerHandler<OffchainV
[user],
message,
eventId,
vote.daoId
vote.daoId,
{ addresses: { address: vote.voter } }
);
}

Expand All @@ -126,7 +127,6 @@ export class OffchainVoteCastTriggerHandler extends BaseTriggerHandler<OffchainV
: offchainVoteCastMessages.withoutReason;

return replacePlaceholders(messageTemplate, {
address: vote.voter,
daoId: vote.daoId,
proposalTitle: vote.proposalTitle,
...(hasReason && { reason: vote.reason! })
Expand Down
2 changes: 2 additions & 0 deletions apps/integrated-tests/tests/telegram/offchain-vote-cast-trigger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ describe('Offchain Vote Cast Trigger - Integration Test', () => {
expect(message.text).toContain('🗳️');
expect(message.text).toContain(proposalTitle);
expect(message.text).toContain('Reason: "Fully support this initiative!"');
expect(message.text).toContain('vitalik.eth');
expect(message.text).not.toContain(voterAddress);
});

test('should NOT send duplicate notifications for same offchain vote', async () => {
Expand Down
Loading