[codex] Add sentinel readiness status#886
Draft
deanbaker wants to merge 1 commit into
Draft
Conversation
00986a8 to
896d59c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Context
We want to support an automated sentinel-drop pipeline that runs once a day during low-traffic windows. That pipeline should only drop
_spirit_sentinelwhen Spirit is actually ready to proceed to cutover.For multi-day migrations, the sentinel table can exist for a long time while copy/checksum work is still in progress. With the current table-existence-only signal, automation cannot distinguish "sentinel exists because cutover is deferred and ready" from "sentinel exists because the migration is still copying/checksumming." Dropping it too early can remove the operator safety gate before Spirit has reached the cutover wait point.
Summary
statuscolumn to Spirit-created sentinel tables.status = 'copying'.status = 'ready'only when Spirit reaches the sentinel wait point before cutover.statuscolumn, Spirit still waits for it to be dropped.migrateandmove.Operator Impact
Automation can now query the sentinel row and only drop the table when it sees
ready, making daily low-traffic cutover windows safe for migrations that run across multiple days.Validation
go test ./pkg/migration ./pkg/move -run '^$'