Namespace JSON schema helpers under JSON ingestion by jwils · Pull Request #1203 · block/elasticgraph

jwils · 2026-05-20T19:57:06Z

Why

After the move-only PR preserves rename detection, put the moved helper constants under the ElasticGraph::JSONIngestion namespace.

What

Namespace the moved JSON Schema helper classes and RBS signatures
Update schema_definition references and tests to use the new qualified constants

Risk Assessment

Medium - namespace-only behavior should be unchanged, but it updates call sites across schema_definition.

References

Stacked on Move JSON schema helpers to json ingestion gem #1201.
Local lint, type check, schema artifact checks, and documentation coverage passed while building this split.

myronmarston · 2026-05-22T22:10:39Z

+                "id" => {
+                  "description" => "The unique identifier of the record.",
+                  "type" => "string",
+                  "maxLength" => ElasticGraph::DEFAULT_MAX_KEYWORD_LENGTH


Suggested change

"maxLength" => ElasticGraph::DEFAULT_MAX_KEYWORD_LENGTH

"maxLength" => DEFAULT_MAX_KEYWORD_LENGTH

Now that the outer module is ElasticGraph and not ElasticGraph::JSONIngestion, this can resolve without the ElasticGraph prefix.

Can you apply this throughout the PR?

myronmarston · 2026-05-22T22:12:12Z

+          :missing_necessary_fields
+        )
+          def json_schema_version
+            json_schema.fetch(ElasticGraph::JSON_SCHEMA_VERSION_KEY)


Suggested change

json_schema.fetch(ElasticGraph::JSON_SCHEMA_VERSION_KEY)

json_schema.fetch(JSON_SCHEMA_VERSION_KEY)

myronmarston · 2026-05-22T22:12:20Z

+              old_type_name_by_current_name = {} # : ::Hash[::String, ::String]
+
+              defs = json_schema.fetch("$defs").to_h do |type_name, type_def|
+                if type_name != ElasticGraph::EVENT_ENVELOPE_JSON_SCHEMA_NAME && (properties = type_def["properties"])


Suggested change

if type_name != ElasticGraph::EVENT_ENVELOPE_JSON_SCHEMA_NAME && (properties = type_def["properties"])

if type_name != EVENT_ENVELOPE_JSON_SCHEMA_NAME && (properties = type_def["properties"])

myronmarston · 2026-05-22T22:14:29Z

-                  field_type: field_type,
-                  fully_qualified_path: field_path.fully_qualified_path_in_index
-                )
+            def identify_missing_necessary_fields_for_index_def(object_type, index_def, json_schema_resolver)


Funny that we had this unused argument...

myronmarston · 2026-05-22T22:28:45Z

      private

-      def json_schema_with_metadata_merger: () -> Indexing::JSONSchemaWithMetadata::Merger
+      def json_schema_with_metadata_merger: () -> ::ElasticGraph::JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger


Suggested change

def json_schema_with_metadata_merger: () -> ::ElasticGraph::JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger

def json_schema_with_metadata_merger: () -> JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger

myronmarston · 2026-05-22T22:28:58Z

      @current_public_json_schema: ::Hash[::String, untyped]?
      @latest_versioned_json_schema: ::Hash[::String, untyped]?
-      @json_schema_with_metadata_merger: Indexing::JSONSchemaWithMetadata::Merger?
+      @json_schema_with_metadata_merger: ::ElasticGraph::JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger?


Suggested change

@json_schema_with_metadata_merger: ::ElasticGraph::JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger?

@json_schema_with_metadata_merger: JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger?

myronmarston · 2026-05-22T22:30:50Z

        def mapping: () -> ::Hash[::String, untyped]
        def json_schema: () -> ::Hash[::String, untyped]
-        def json_schema_metadata: () -> JSONSchemaFieldMetadata
+        def json_schema_metadata: () -> ::ElasticGraph::JSONIngestion::SchemaDefinition::Indexing::JSONSchemaFieldMetadata


Suggested change

def json_schema_metadata: () -> ::ElasticGraph::JSONIngestion::SchemaDefinition::Indexing::JSONSchemaFieldMetadata

def json_schema_metadata: () -> JSONIngestion::SchemaDefinition::Indexing::JSONSchemaFieldMetadata

The ::ElasticGraph:: prefix shouldn't be needed in any of these RBS files since you're within module ElasticGraph. Can you apply this to all the RBS files?

myronmarston · 2026-05-22T22:37:28Z

+          # @private
+          class MissingNecessaryField < ::Data
+            # @dynamic initialize, with, field_type, fully_qualified_path
+          end


Suggested change

# @private

class MissingNecessaryField < ::Data

# @dynamic initialize, with, field_type, fully_qualified_path

end

Doesn't seem like this is needed?

jwils mentioned this pull request May 20, 2026

Add JSON ingestion schema extension modules #1204

Open

jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 7bc0045 to 6267113 Compare May 20, 2026 20:03

jwils force-pushed the joshuaw/json-ingestion-extension branch from 461ba24 to 64ff2af Compare May 20, 2026 20:03

jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 6267113 to 040cea2 Compare May 20, 2026 20:15

myronmarston reviewed May 20, 2026

View reviewed changes

Comment thread ...json_ingestion/lib/elastic_graph/json_ingestion/schema_definition/indexing/event_envelope.rb Outdated

myronmarston reviewed May 20, 2026

View reviewed changes

Comment thread ...json_ingestion/lib/elastic_graph/json_ingestion/schema_definition/indexing/event_envelope.rb

jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from 040cea2 to e6a4787 Compare May 21, 2026 02:49

jwils force-pushed the joshuaw/json-ingestion-extension branch from 64ff2af to 7d4becc Compare May 21, 2026 02:49

jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from e6a4787 to eb21230 Compare May 21, 2026 13:43

jwils marked this pull request as ready for review May 22, 2026 18:23

jwils requested review from BrianSigafoos-SQ, ayousufi, bsorbo and jwondrusch as code owners May 22, 2026 18:23

Namespace JSON schema helpers under JSON ingestion

2afdcd4

myronmarston reviewed May 22, 2026

View reviewed changes

jwils force-pushed the joshuaw/json-ingestion-extension branch from 7d4becc to e64b589 Compare May 22, 2026 22:41

jwils force-pushed the joshuaw/json-ingestion-helper-namespace branch from eb21230 to 2afdcd4 Compare May 22, 2026 22:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Namespace JSON schema helpers under JSON ingestion#1203

Namespace JSON schema helpers under JSON ingestion#1203
jwils wants to merge 1 commit into
joshuaw/json-ingestion-extensionfrom
joshuaw/json-ingestion-helper-namespace

jwils commented May 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

myronmarston May 22, 2026

Uh oh!

myronmarston May 22, 2026

Uh oh!

myronmarston May 22, 2026

Uh oh!

myronmarston May 22, 2026

Uh oh!

myronmarston May 22, 2026

Uh oh!

myronmarston May 22, 2026

Uh oh!

myronmarston May 22, 2026

Uh oh!

myronmarston May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	"maxLength" => ElasticGraph::DEFAULT_MAX_KEYWORD_LENGTH
	"maxLength" => DEFAULT_MAX_KEYWORD_LENGTH

	json_schema.fetch(ElasticGraph::JSON_SCHEMA_VERSION_KEY)
	json_schema.fetch(JSON_SCHEMA_VERSION_KEY)

	if type_name != ElasticGraph::EVENT_ENVELOPE_JSON_SCHEMA_NAME && (properties = type_def["properties"])
	if type_name != EVENT_ENVELOPE_JSON_SCHEMA_NAME && (properties = type_def["properties"])

	def json_schema_with_metadata_merger: () -> ::ElasticGraph::JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger
	def json_schema_with_metadata_merger: () -> JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger

	@json_schema_with_metadata_merger: ::ElasticGraph::JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger?
	@json_schema_with_metadata_merger: JSONIngestion::SchemaDefinition::Indexing::JSONSchemaWithMetadata::Merger?

	def json_schema_metadata: () -> ::ElasticGraph::JSONIngestion::SchemaDefinition::Indexing::JSONSchemaFieldMetadata
	def json_schema_metadata: () -> JSONIngestion::SchemaDefinition::Indexing::JSONSchemaFieldMetadata

Conversation

jwils commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What

Risk Assessment

References

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jwils commented May 20, 2026 •

edited

Loading