-
Notifications
You must be signed in to change notification settings - Fork 10
perf(staged): pre-compute git context before create-PR agent session #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
matt2e
wants to merge
4
commits into
main
Choose a base branch
from
faster-create-pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a3eef30
perf(staged): pre-compute git context before create-PR agent session
matt2e 297508f
fix(staged): fix user message rendering when diff contains XML tags
matt2e c6a3db0
perf(staged): drop full diff from pre-computed create-PR context
matt2e 05e2828
fix(staged): resolve code review comments on create-PR pre-computation
matt2e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| mod cli; | ||
| pub(crate) mod cli; | ||
| mod commit; | ||
| mod diff; | ||
| mod files; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
truncate_diffindexes the string with a raw byte offset (&diff[..DIFF_TRUNCATION_LIMIT]). If a large diff contains multibyte UTF-8 text, hitting the 50,000-byte cutoff in the middle of a character will panic, which can crashcreate_prinstead of gracefully falling back. This is reproducible when the diff exceeds the limit and includes non-ASCII content (for example in source strings/comments or filenames), so truncation needs to find a valid character boundary before slicing.Useful? React with 👍 / 👎.