-
Notifications
You must be signed in to change notification settings - Fork 45
Add pull_request_target workflows for community PRs #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2c7c2f9
Add pull_request_target workflows for community PRs
AmyLGalles 7f0a183
Merge branch 'main' into add-pull-request-target-workflows
AmyLGalles 8626e44
Fix workflow lint errors
AmyLGalles fb25ff8
Fix critical workflow issues for pull_request_target
AmyLGalles 2ab8488
Skip secrets-dependent jobs for fork PRs in base workflows
AmyLGalles 8e63c2a
Fix build-wasm-internal.yml to support pull_request_target properly
AmyLGalles 5e7dcdb
Merge branch 'main' into add-pull-request-target-workflows
harr1424 3320a5c
Merge branch 'main' into add-pull-request-target-workflows
AmyLGalles 495e731
Remove unnecessary enforce-labels-target workflow
AmyLGalles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # This workflow is intended to be run when we need to build the Android SDK and produce artifacts that require secrets | ||
| # when the PR source branch does not have access to secrets (e.g. a fork). | ||
| # This workflow will run in the context of the target of the PR and have access to secrets. | ||
| # This should only be done after reviewing the PR to ensure that no malicious code has been introduced, | ||
| # as it could allow the code on the forked branch to have access to workflow secrets. | ||
|
|
||
| name: Build Android on PR Target | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: [opened, synchronize, reopened] | ||
| branches: | ||
| - main | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| check-run: | ||
| name: Check PR run | ||
| uses: bitwarden/gh-actions/.github/workflows/check-run.yml@main | ||
| permissions: | ||
| contents: read | ||
|
|
||
| run-workflow: | ||
| name: Build Android | ||
| needs: check-run | ||
| if: ${{ github.event.pull_request.head.repo.full_name != github.repository }} | ||
| uses: ./.github/workflows/build-android.yml | ||
|
AmyLGalles marked this conversation as resolved.
|
||
| secrets: inherit | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| id-token: write | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # This workflow is intended to be run when we need to build the WASM SDK and produce artifacts that require secrets | ||
| # when the PR source branch does not have access to secrets (e.g. a fork). | ||
| # This workflow will run in the context of the target of the PR and have access to secrets. | ||
| # This should only be done after reviewing the PR to ensure that no malicious code has been introduced, | ||
| # as it could allow the code on the forked branch to have access to workflow secrets. | ||
|
|
||
| name: Build @bitwarden/sdk-internal on PR Target | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: [opened, synchronize, reopened] | ||
| branches: | ||
| - main | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| check-run: | ||
| name: Check PR run | ||
| uses: bitwarden/gh-actions/.github/workflows/check-run.yml@main | ||
| permissions: | ||
| contents: read | ||
|
|
||
| run-workflow: | ||
| name: Build @bitwarden/sdk-internal | ||
| needs: check-run | ||
| if: ${{ github.event.pull_request.head.repo.full_name != github.repository }} | ||
| uses: ./.github/workflows/build-wasm-internal.yml | ||
|
AmyLGalles marked this conversation as resolved.
|
||
| secrets: inherit | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
| id-token: write | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.