Skip to content

[BRE-1935] Phase 2: Convert cd.yml to trigger-actions caller #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AmyLGalles wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[BRE-1935] Phase 2: Convert cd.yml to trigger-actions caller #136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
756e950
[BRE-1935] Phase 2: Convert cd.yml to trigger-actions caller
AmyLGalles Jul 30, 2026
b2d6290
Merge branch 'main' into agalles/BRE-1935-finalize-source-cd
AmyLGalles Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 59 additions & 12 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# This workflow triggers deployment to npm via bitwarden/deploy

name: Node.js Package

on:
Expand All @@ -8,26 +10,43 @@ on:

permissions: {}

concurrency:
group: cd-${{ github.ref }}
cancel-in-progress: true

jobs:
build:
name: Build npm bundle
format:
name: Format
runs-on: ubuntu-24.04

permissions:
contents: read
steps:
- name: Checkout
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false

- name: Install NodeJS
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: 20

- name: Install dependencies
run: npm ci

- name: Run format
run: npm run lint

build:
name: Build
needs: format
runs-on: ubuntu-24.04
permissions:
contents: read
steps:
- name: Checkout
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false

- name: Install NodeJS
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: 20
cache: npm
Expand All @@ -51,7 +70,35 @@ jobs:
- name: Upload build artifact
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: passwordless-nodejs-${{ steps.version.outputs.package_version }}-npm-build
path: "*dist/**"
if-no-files-found: error
name: packages
path: |
dist
package.json

trigger-deploy:
name: Trigger deployment
if: ${{ github.event_name == 'release' }}

@claude claude Bot Oct 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ CRITICAL: trigger-deploy can never run because the workflow has no release trigger.

Details and fix

The on: block (lines 5-9) still only declares push to main and workflow_dispatch, so github.event_name is never release. The job is always skipped, which means no deployment event ever reaches bitwarden/deploy. The PR description says the job is "Triggered on release: published events", but that trigger was never added.

Add the trigger:

on:
  push:
    branches:
      - main
  release:
    types: [published]
  workflow_dispatch:

Also, github.event.release.tag_name (line 103) only gets a value on release events.

needs: build
runs-on: ubuntu-24.04
permissions:
contents: read
id-token: write
steps:
- name: Log in to Azure
uses: bitwarden/gh-actions/azure-login@main
with:
subscription_id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
tenant_id: ${{ secrets.AZURE_TENANT_ID }}
client_id: ${{ secrets.AZURE_CLIENT_ID }}

- name: Trigger deployment to deploy repo
uses: bitwarden/gh-actions/trigger-actions@main
with:
azure_subscription_id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
azure_tenant_id: ${{ secrets.AZURE_TENANT_ID }}
azure_client_id: ${{ secrets.AZURE_CLIENT_ID }}
task: deploy-passwordless-nodejs
data: |
{
"tag": "${{ github.event.release.tag_name }}"
}
Comment on lines +101 to +104

@claude claude Bot Oct 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ QUESTION: How does the receiver find this run's packages artifact when the payload only sends tag?

Details

The PR description says bitwarden/deploy will "Download build artifacts from this workflow run". A cross-repository artifact download usually needs the source run_id (and the repository). Neither is in data. If the receiver looks the run up by tag or branch instead, that works, but the generic artifact name packages gets reused by every push to main. Should "run_id": "${{ github.run_id }}" be forwarded here?

Loading