[PM-31117] feat: Add SDK-managed PIN unlock - #2995
Draft
matt-livefront wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
app:password-manager
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## matt/PM-37877-km-state-bridge #2995 +/- ##
=================================================================
+ Coverage 79.58% 79.61% +0.02%
=================================================================
Files 1170 1171 +1
Lines 75325 75358 +33
=================================================================
+ Hits 59950 59993 +43
+ Misses 15375 15365 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Claude Code is reviewing this pull request... If this comment does not update with results, check the Actions log. |
quexten
approved these changes
Aug 28, 2026
quexten
left a comment
quexten
left a comment
Contributor
There was a problem hiding this comment.
Sweet! After we roll out and remove the feature flag, that should drop a fair bit of logic from mobile's codebase :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-31117
📔 Objective
Adds support for using the SDK for PIN management.
pm-31059-sdk-pin-unlockfeature flag and exposes the SDK'suserCryptoManagement().pinSettings()client for SDK-managed PIN state.InitUserCryptoMethod.pinState,PinSettingsClient.validatePin) instead of the legacy envelope/key parameters the app previously read and passed in itself.setPins) and removal now unconditionally dual-write to both the legacy iOS-managed state and the new SDK-managed state, so the flag can be toggled in either direction without leaving a stale or missing PIN unlock method.