Skip to content

[PM-27135] feat: Add Use Passkey screen - #2947

Open
morganzellers-bw wants to merge 5 commits into
pm-27134-testharness-register-passkeys-uifrom
pm-27135-testharness-use-passkeys-ui
Open

[PM-27135] feat: Add Use Passkey screen#2947
morganzellers-bw wants to merge 5 commits into
pm-27134-testharness-register-passkeys-uifrom
pm-27135-testharness-use-passkeys-ui

Conversation

@morganzellers-bw

@morganzellers-bw morganzellers-bw commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

PM-27135

📔 Objective

Fourth PR in a 5-PR stack adding SDK-backed passkey test scenarios to TestHarness. Stacked on #2946.

  • Adds the "Use Passkey (SDK)" scenario: lists credentials registered via SDKPasskeyService.registeredCredentials, and asserts against the tapped credential's specific credential ID and relying party ID via SDKPasskeyService.assertPasskey, showing the resulting relying party ID and username.
  • Wires the new screen into the scenario picker and root navigation.

📸 Screenshots

usePasskey1 usePasskey2 usePasskey3

Stack: #2945#2946#2947#2948

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the new "Use Passkey (SDK)" TestHarness scenario: UsePasskeyProcessor/State/View/Action/Effect, the GetAssertionResult fixture, and the routing wired through RootRoute, RootCoordinator, and ScenarioPickerState. The screen follows the same Coordinator-Processor-Store-View shape as the sibling RegisterPasskey screen, all new Localizable.strings keys referenced by the view are defined, and the fixture lives under a Fixtures/ directory that project-bwth.yml excludes from the shipping framework target. Processor tests cover load success/failure, credential-ID and RP-ID pass-through, and assertion success/failure. Both prior findings on this PR (premature empty state, duplicate showScenarioPicker()) are resolved and no new blocking issues were found.

Code Review Details

No findings at or above the reporting threshold.

PR Metadata Assessment

  • QUESTION: The Screenshots section is still a placeholder comment for a PR that adds a new screen — please attach captures of the loading, empty, success, and failure states before merge.

Comment thread TestHarnessShared/UI/Autofill/Passkey/UsePasskeyView.swift Outdated
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 544b847 to 5065ad1 Compare August 7, 2026 21:56
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.52%. Comparing base (2bd6942) to head (42b2e54).

Additional details and impacted files
@@                              Coverage Diff                              @@
##           pm-27134-testharness-register-passkeys-ui    #2947      +/-   ##
=============================================================================
- Coverage                                      79.53%   79.52%   -0.02%     
=============================================================================
  Files                                           1169     1169              
  Lines                                          75095    75095              
=============================================================================
- Hits                                           59730    59720      -10     
- Misses                                         15365    15375      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 5065ad1 to ad91844 Compare August 7, 2026 22:32
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from ad91844 to 2daf425 Compare August 7, 2026 22:38
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 2daf425 to 5669016 Compare August 10, 2026 14:14
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 5669016 to c2a8b7a Compare August 10, 2026 14:26
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from c2a8b7a to 9d219bb Compare August 10, 2026 14:55
@morganzellers-bw morganzellers-bw changed the title [PM-27135] feat: Add SDK-backed Use Passkey (SDK) screen [PM-27135] feat: Add Use Passkey screen Aug 10, 2026
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 9d219bb to eedacf1 Compare August 10, 2026 17:00
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch 2 times, most recently from 9f46c09 to eedacf1 Compare August 12, 2026 17:29
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from eedacf1 to 8f59089 Compare August 12, 2026 17:47
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 47367b2 to 2003012 Compare August 17, 2026 19:46
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 2003012 to 3200446 Compare August 17, 2026 20:16
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 3200446 to 7881478 Compare August 18, 2026 16:26
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 7881478 to e14fe11 Compare August 18, 2026 16:43
@github-actions

Copy link
Copy Markdown
Contributor

Warning

@morganzellers-bw Uploading code coverage report failed. Please check the "Upload to codecov.io" step of Process Test Reports job for more details.

@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from e14fe11 to cc929d1 Compare August 18, 2026 17:21
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from cc929d1 to 98fc0b7 Compare August 18, 2026 17:30
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 98fc0b7 to 7cf5387 Compare August 19, 2026 14:12
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 7cf5387 to 0064e31 Compare August 20, 2026 16:47
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 0064e31 to 713c468 Compare August 25, 2026 20:41
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 713c468 to 21485fc Compare August 26, 2026 19:08
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from 21485fc to bcaf09d Compare August 27, 2026 16:38
Adds the "Use Passkey" scenario: lists credentials registered via
PasskeyService.registeredCredentials, and asserts against the
tapped credential's specific credential ID and relying party ID via
PasskeyService.assertPasskey, showing the resulting relying party
ID and username. Wires it into the scenario picker and root
navigation.
@morganzellers-bw
morganzellers-bw force-pushed the pm-27135-testharness-use-passkeys-ui branch from bcaf09d to 42b2e54 Compare August 27, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context t:feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant