Skip to content

[PM-37608] Expand integration testing#1140

Open
BTreston wants to merge 6 commits into
mainfrom
ac/pm-37608-integration-tests
Open

[PM-37608] Expand integration testing#1140
BTreston wants to merge 6 commits into
mainfrom
ac/pm-37608-integration-tests

Conversation

@BTreston

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37608

📔 Objective

Adds integration tests for Entra and Okta

📸 Screenshots

@BTreston BTreston requested a review from a team as a code owner June 10, 2026 17:55
@BTreston BTreston requested a review from sven-bitwarden June 10, 2026 17:55
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds Jest integration tests for the Entra ID and Okta directory services, mirroring the existing Google Workspace integration test pattern. The change set is entirely tests and fixtures (no production code), and credentials are sourced from a utils/.env file rather than hardcoded. Fixtures correctly reflect the GroupEntry / UserEntry JSON shapes (sets serialized as arrays for Jsonify) and align with the expected test tenant seed data. Test scenarios cover both happy path, users-only / groups-only modes, filtering, and invalid-credential failure.

Code Review Details
  • 🎨: Okta filter test under-asserts users — should verify full filtered set, matching the Entra equivalent's strictness
    • libs/services/directory-services/okta-directory.service.integration.spec.ts:85-87

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (24d69d9) to head (3643bda).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1140   +/-   ##
============================
============================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant