[PM-36379] fix: Show the item type in the save snackbar

[andrebispo5]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-36379

📔 Objective

• Saving a card showed "Item added" or "Item saved", which doesn't tell you what you actually saved.
• The snackbar now names the type, so creating or editing a card reads "Card saved".
• Did the same for the rest: logins, identities, secure notes, SSH keys, bank accounts, licenses, and passports.
• Create and edit share one message now, since "Card saved" reads fine for both.

📸 Screenshots

| Before |

| After |

[codecov]

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.25%. Comparing base (36bd55a) to head (2a1a1c5).

Files with missing lines	Patch %	Lines
.../ui/vault/feature/addedit/VaultAddEditViewModel.kt	36.36%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7308      +/-   ##
==========================================
+ Coverage   85.22%   86.25%   +1.02%     
==========================================
  Files        1033      898     -135     
  Lines       68135    65601    -2534     
  Branches     9940     9868      -72     
==========================================
- Hits        58070    56582    -1488     
+ Misses       6575     5550    -1025     
+ Partials     3490     3469      -21     

Flag	Coverage Δ
app-data	17.92% <0.00%> (-0.01%)	⬇️
app-ui-auth-tools	18.95% <0.00%> (-0.34%)	⬇️
app-ui-platform	16.36% <0.00%> (-0.01%)	⬇️
app-ui-vault	27.29% <36.36%> (-0.64%)	⬇️
authenticator	6.06% <0.00%> (-0.03%)	⬇️
lib-core-network-bridge	4.08% <0.00%> (-0.03%)	⬇️
lib-data-ui	1.20% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the type-specific save snackbar change in VaultAddEditViewModel, the eight new string resources, and the accompanying test updates. The new savedSnackbarMessage getter reads state.cipherType, the same exhaustive source of truth already used by screenDisplayName, and that value is set once from the navigation args and never mutated, so add, edit, and clone flows all resolve the correct type. Autofill save and passkey registration paths still short-circuit to ExitApp before the snackbar, so they are unaffected. New string names follow the content-derived snake_case convention, and regression tests cover the card create and card edit cases plus the updated login expectations.

Code Review Details

• ♻️ : new_item_created is now unreferenced after its only usage was replaced
  • ui/src/main/res/values/strings.xml:123

[Copilot]

Pull request overview

Updates the vault add/edit save snackbar copy so it includes the saved item type (e.g., “Card saved”) instead of generic “Item saved/Item added”, improving clarity across supported cipher types.

Changes:

• Added new string resources for per-item-type “*_saved” snackbar messages.
• Updated VaultAddEditViewModel to use a cipher-type-derived snackbar message for both create and update success paths.
• Updated and extended unit tests to assert the new snackbar messages (including new card coverage).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
ui/src/main/res/values/strings.xml	Adds new per-item-type “saved” strings used by the snackbar.
app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt	Uses a new savedSnackbarMessage derived from cipherType for save success snackbar text.
app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt	Updates expectations for the snackbar message and adds card-specific save snackbar tests.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[claude]

♻️ DEBT: new_item_created is now unreferenced and can be removed.

Details

This PR replaced the only Kotlin usage of new_item_created (VaultAddEditViewModel.kt:2036) with state.savedSnackbarMessage. A search across the repo shows the resource is now only declared in ui/src/main/res/values/strings.xml:123 and its translated variants, with no code references remaining.

Removing the base declaration keeps the translation source clean so translators aren't maintaining dead copy. item_updated is still used (VaultItemListingViewModel.kt:2378, VaultMoveToOrganizationViewModel.kt:342, VaultAddEditViewModel.kt:2457), so only new_item_created is affected.

[david-livefront]

We should remove this if it's not needed

[david-livefront]

👍