fix: always validate non_witness_utxo in add_foreign_utxo#461
Open
tnull wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix: always validate non_witness_utxo in add_foreign_utxo#461tnull wants to merge 1 commit intobitcoindevkit:masterfrom
tnull wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Previously, non_witness_utxo was only validated when witness_utxo was None. An attacker could supply both a valid witness_utxo and a non_witness_utxo with the wrong txid, bypassing the txid/outpoint checks entirely. Restructure the validation so non_witness_utxo is always checked when present, regardless of whether witness_utxo is also set. Only require at least one of the two to exist. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 80.04% 80.21% +0.17%
==========================================
Files 24 24
Lines 5336 5347 +11
Branches 242 243 +1
==========================================
+ Hits 4271 4289 +18
+ Misses 987 980 -7
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, non_witness_utxo was only validated when witness_utxo was None. An attacker could supply both a valid witness_utxo and a non_witness_utxo with the wrong txid, bypassing the txid/outpoint checks entirely.
Restructure the validation so non_witness_utxo is always checked when present, regardless of whether witness_utxo is also set. Only require at least one of the two to exist.
Checklists
All Submissions:
just pbefore pushingBugfixes: