fix: avoid panic on hardened derivation paths in PSBT key origins#458
Open
tnull wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix: avoid panic on hardened derivation paths in PSBT key origins#458tnull wants to merge 1 commit intobitcoindevkit:masterfrom
tnull wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
The verify_key closure in derive_from_psbt_key_origins called .expect() on xpub.derive_pub(), which panics when the derivation path contains hardened steps. Since PSBT data is untrusted, a maliciously crafted bip32_derivation entry with hardened steps could crash the application. Replace the panic with graceful error handling by returning false on derivation failure. Co-Authored-By: HAL 9000 Signed-off-by: Elias Rohrer <dev@tnull.de>
tnull
force-pushed
the
2026-04-fix-psbt-hardened-panic
branch
from
36867f6 to
507f08a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
==========================================
+ Coverage 80.04% 80.24% +0.20%
==========================================
Files 24 24
Lines 5336 5346 +10
Branches 242 242
==========================================
+ Hits 4271 4290 +19
+ Misses 987 979 -8
+ Partials 78 77 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The verify_key closure in derive_from_psbt_key_origins called .expect() on xpub.derive_pub(), which panics when the derivation path contains hardened steps. Since PSBT data is untrusted, a maliciously crafted bip32_derivation entry with hardened steps could crash the application.
Replace the panic with graceful error handling by returning false on derivation failure.
Checklists
All Submissions:
just pbefore pushingBugfixes: