BIP352: be explicit for the input_hash corner case#1902
Merged
jonatack merged 1 commit intobitcoin:masterfrom Jul 25, 2025
Merged
BIP352: be explicit for the input_hash corner case#1902jonatack merged 1 commit intobitcoin:masterfrom
jonatack merged 1 commit intobitcoin:masterfrom
Conversation
jonatack
added
the
Proposed BIP modification
jonatack
changed the title
Contributor
|
ACK |
jonatack
reviewed
Jul 25, 2025
Member
There was a problem hiding this comment.
LGTM
Addresses bitcoin-core/secp256k1#1698 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is statistically improbable, e.g., we don't yet know of a hash preimage that results in an output = 0 or greater than the curve order, we still want to be explicit on how to handle this (same as we do for the tweaks themselves).